Thanks for the fix! I still have the developer role over at OpenSSO, so I should be able to commit it.

However that code belongs to Oracle and I no longer work there, so, unfortunately, I don’t think I can push it to drupal.org

Cheers,

Pat

I was looking through your module and might’ve found a bug:
http://pastie.org/823011

// Need to parse name/value pairs, to get value for Drupal username
attribute

$lines = explode(“\n”, $response->data);
reset($lines);

foreach ($lines as $line) {
if ($line == (‘userdetails.attribute.name=’ .
OPENSSO_DRUPAL_USERNAME_ATTRIBUTE)) {

// ‘current’ line holds attribute value
// 28 points to character after ‘userdetails.attribute.value=’
$name = substr(current($lines), 28);
break;
}
next($lines); // <——— This was missing
}

return $name;
} // function _opensso_get_name

Thanks for writing this module, please upload it to drupal.org A lot
of people can contribute and benefit from bug fixes while it's on
drupal.org.

Cheers,

Yonas